Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1df26c2

Browse filesBrowse files
committed
minor #38117 [Debug] Skip a test that was meant for HHVM (derrabus)
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Skip a test that was meant for HHVM | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A This PR skips a test that fails on php 8. If I read the test correctly, it is meant to run on HHVM, so I assumed it's save to skip it if we're on PHP. Commits ------- bf62a4d [Debug] Skip a test that was meant for HHVM.
2 parents 336946a + bf62a4d commit 1df26c2
Copy full SHA for 1df26c2

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,10 @@ public function testHandleErrorException()
558558
*/
559559
public function testHandleFatalErrorOnHHVM()
560560
{
561+
if (!\defined('HHVM_VERSION')) {
562+
$this->markTestSkipped('This test requires HHVM.');
563+
}
564+
561565
try {
562566
$handler = ErrorHandler::register();
563567

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.