Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 190b4b7

Browse filesBrowse files
committed
Remove deprecated slack DSN check
1 parent eef04ce commit 190b4b7
Copy full SHA for 190b4b7

File tree

2 files changed

+0
-14
lines changed
Filter options

2 files changed

+0
-14
lines changed

‎src/Symfony/Component/Notifier/Bridge/Slack/SlackTransportFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/Slack/SlackTransportFactory.php
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ public function create(Dsn $dsn): TransportInterface
3131
throw new UnsupportedSchemeException($dsn, 'slack', $this->getSupportedSchemes());
3232
}
3333

34-
if ('/' !== $dsn->getPath() && null !== $dsn->getPath()) {
35-
throw new IncompleteDsnException('Support for Slack webhook DSN has been dropped since 5.2 (maybe you haven\'t updated the DSN when upgrading from 5.1).');
36-
}
37-
3834
$accessToken = $this->getUser($dsn);
3935
$channel = $dsn->getOption('channel');
4036
$host = 'default' === $dsn->getHost() ? null : $dsn->getHost();

‎src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportFactoryTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportFactoryTest.php
-10Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,6 @@ public function createProvider(): iterable
4545
];
4646
}
4747

48-
public function testCreateWithDeprecatedDsn()
49-
{
50-
$factory = $this->createFactory();
51-
52-
$this->expectException(InvalidArgumentException::class);
53-
$this->expectExceptionMessage('Support for Slack webhook DSN has been dropped since 5.2 (maybe you haven\'t updated the DSN when upgrading from 5.1).');
54-
55-
$factory->create(new Dsn('slack://default/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX'));
56-
}
57-
5848
public function supportsProvider(): iterable
5949
{
6050
yield [true, 'slack://xoxb-TestToken@host?channel=testChannel'];

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.