Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 187e665

Browse filesBrowse files
committed
[Cache][FrameworkBundle] Add cache adapters in semantic configuration
1 parent db208e3 commit 187e665
Copy full SHA for 187e665

File tree

4 files changed

+25
-5
lines changed
Filter options

4 files changed

+25
-5
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+15Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,22 @@ private function addCacheSection(ArrayNodeDefinition $rootNode)
557557
->info('Cache configuration')
558558
->addDefaultsIfNotSet()
559559
->fixXmlConfig('pool')
560+
->fixXmlConfig('adapter')
560561
->children()
562+
->arrayNode('adapters')
563+
->useAttributeAsKey('name')
564+
->prototype('array')
565+
->children()
566+
->scalarNode('parent')
567+
->info('The parent cache pool adapter service.')
568+
->end()
569+
->integerNode('default_lifetime')->end()
570+
->scalarNode('provider')
571+
->info('The service name to use as provider when the specified adapter needs one.')
572+
->end()
573+
->end()
574+
->end()
575+
->end()
561576
->arrayNode('pools')
562577
->useAttributeAsKey('name')
563578
->prototype('array')

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,6 +1022,14 @@ private function registerPropertyInfoConfiguration(array $config, ContainerBuild
10221022

10231023
private function registerCacheConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
10241024
{
1025+
foreach ($config['adapters'] as $name => $adapterConfig) {
1026+
$adapterDefinition = clone $container->getDefinition($adapterConfig['parent'] ?: 'cache.adapter.'.$name);
1027+
$adapterDefinition->setArguments($adapterConfig['provider'] ?: array());
1028+
$adapterDefinition->setPublic(false);
1029+
1030+
$container->setDefinition('cache.adapter.'.$name, $adapterDefinition);
1031+
}
1032+
10251033
foreach ($config['pools'] as $name => $poolConfig) {
10261034
$poolDefinition = new DefinitionDecorator($poolConfig['adapter']);
10271035
$poolDefinition->setPublic($poolConfig['public']);

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/cache_pools.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/cache_pools.xml
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@
1313
<service id="cache.adapter.shared" alias="cache.adapter.filesystem" />
1414
<service id="cache.adapter.local" alias="cache.adapter.filesystem" />
1515

16-
<service id="cache.pool.shared" parent="cache.adapter.shared">
17-
<tag name="cache.pool" clearer="cache.default_pools_clearer" />
18-
</service>
19-
20-
<service id="cache.pool.local" parent="cache.adapter.local">
16+
<service id="cache.pool.app" parent="cache.adapter.shared">
2117
<tag name="cache.pool" clearer="cache.default_pools_clearer" />
2218
</service>
2319

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ protected static function getBundleDefaultConfig()
268268
'packages' => array(),
269269
),
270270
'cache' => array(
271+
'adapters' => array(),
271272
'pools' => array(),
272273
),
273274
);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.