Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 17d23a7

Browse filesBrowse files
fabpotfabpot
committed
bug #23157 Fix the usage of FrameworkBundle in debug mode without Stopwatch (stof)
This PR was merged into the 3.4 branch. Discussion ---------- Fix the usage of FrameworkBundle in debug mode without Stopwatch | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a #23148 removed the loading of the debug.xml file when Stopwatch is not installed. While all services defined in it are related to Stopwatch, the parameter was not (it is related to dumping the debug container in the compiler pass), which was breaking the usage of the bundle in debug mode without Stopwatch (exception triggered in the compiler pass) Commits ------- 2ea26c1 Fix the usage of FrameworkBundle in debug mode without Stopwatch
2 parents cc2363f + 2ea26c1 commit 17d23a7
Copy full SHA for 17d23a7

File tree

2 files changed

+4
-4
lines changed
Filter options

2 files changed

+4
-4
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -647,6 +647,10 @@ private function registerDebugConfiguration(array $config, ContainerBuilder $con
647647

648648
$debug = $container->getParameter('kernel.debug');
649649

650+
if ($debug) {
651+
$container->setParameter('debug.container.dump', '%kernel.cache_dir%/%kernel.container_class%.xml');
652+
}
653+
650654
if ($debug && class_exists(Stopwatch::class)) {
651655
$loader->load('debug.xml');
652656
}

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/debug.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/debug.xml
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
55
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
66

7-
<parameters>
8-
<parameter key="debug.container.dump">%kernel.cache_dir%/%kernel.container_class%.xml</parameter>
9-
</parameters>
10-
117
<services>
128
<defaults public="false" />
139

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.