Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 14f8b34

Browse filesBrowse files
committed
deprecate the framework.templating option
1 parent 3644b70 commit 14f8b34
Copy full SHA for 14f8b34

File tree

5 files changed

+8
-1
lines changed
Filter options

5 files changed

+8
-1
lines changed

‎UPGRADE-4.4.md

Copy file name to clipboardExpand all lines: UPGRADE-4.4.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ Form
4949
FrameworkBundle
5050
---------------
5151

52+
* Deprecated the `framework.templating` option, use Twig instead.
5253
* Deprecated support for `templating` engine in `TemplateController`, use Twig instead
5354
* The `$parser` argument of `ControllerResolver::__construct()` and `DelegatingLoader::__construct()`
5455
has been deprecated.

‎UPGRADE-5.0.md

Copy file name to clipboardExpand all lines: UPGRADE-5.0.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@ Form
207207
FrameworkBundle
208208
---------------
209209

210+
* Remved the `framework.templating` option, use Twig instead.
210211
* The project dir argument of the constructor of `AssetsInstallCommand` is required.
211-
212212
* Removed support for `bundle:controller:action` syntax to reference controllers. Use `serviceOrFqcn::method`
213213
instead where `serviceOrFqcn` is either the service ID when using controllers as services or the FQCN of the controller.
214214

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ CHANGELOG
44
4.4.0
55
-----
66

7+
* Deprecated the `framework.templating` option, use Twig instead.
78
* Deprecated support for `templating` engine in `TemplateController`, use Twig instead
89
* Deprecated the `$parser` argument of `ControllerResolver::__construct()` and `DelegatingLoader::__construct()`
910
* Deprecated the `controller_name_converter` and `resolve_controller_name_subscriber` services

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ private function addTemplatingSection(ArrayNodeDefinition $rootNode)
605605
->arrayNode('templating')
606606
->info('templating configuration')
607607
->canBeEnabled()
608+
->setDeprecated('The "%path%.%node%" configuration is deprecated since Symfony 4.4. Use the "twig" service directly instead.')
608609
->beforeNormalization()
609610
->ifTrue(function ($v) { return false === $v || \is_array($v) && false === $v['enabled']; })
610611
->then(function () { return ['enabled' => false, 'engines' => false]; })

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,9 @@ public function testTemplating()
602602
$this->assertEquals('global_hinclude_template', $container->getParameter('fragment.renderer.hinclude.global_template'), '->registerTemplatingConfiguration() registers the global hinclude.js template');
603603
}
604604

605+
/**
606+
* @group legacy
607+
*/
605608
public function testTemplatingCanBeDisabled()
606609
{
607610
$container = $this->createContainerFromFile('templating_disabled');
@@ -872,6 +875,7 @@ public function testTranslatorMultipleFallbacks()
872875
}
873876

874877
/**
878+
* @group legacy
875879
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
876880
*/
877881
public function testTemplatingRequiresAtLeastOneEngine()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.