Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 14f70ae

Browse filesBrowse files
committed
bug #16621 [Console] Fix bug with $output overloading (WouterJ)
This PR was squashed before being merged into the 2.8 branch (closes #16621). Discussion ---------- [Console] Fix bug with $output overloading | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony-standard/issues/887, #16622 | License | MIT | Doc PR | - This is exactly why variable overloading isn't a great idea :) Commits ------- 5764a00 [Console] Fix bug with overloading
2 parents a58df11 + 5764a00 commit 14f70ae
Copy full SHA for 14f70ae

File tree

1 file changed

+2
-2
lines changed
Filter options

1 file changed

+2
-2
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Command/ServerStartCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/ServerStartCommand.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ protected function configure()
7474
*/
7575
protected function execute(InputInterface $input, OutputInterface $output)
7676
{
77-
$output = new SymfonyStyle($input, $output);
77+
$output = new SymfonyStyle($input, $cliOutput = $output);
7878

7979
if (!extension_loaded('pcntl')) {
8080
$output->error(array(
@@ -85,7 +85,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
8585
if ($output->ask('Do you want to execute <info>server:run</info> immediately? [Yn] ', true)) {
8686
$command = $this->getApplication()->find('server:run');
8787

88-
return $command->run($input, $output);
88+
return $command->run($input, $cliOutput);
8989
}
9090

9191
return 1;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.