Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0f59bca

Browse filesBrowse files
committed
feature #11501 [OptionsResolver] Changed order of validation (WouterJ)
This PR was merged into the 2.6-dev branch. Discussion ---------- [OptionsResolver] Changed order of validation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no (I don't think it causes breaks) | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - It's both a new feature and bug fix actually... I let @fabpot decide on this one. <s>@sstok can you please confirm if this fixes #4500 ? I couldn't fully follow that ticket and then I discovered this error. If not, can you please add more information to your ticket about the problems?</s> Commits ------- a4f208b Changed order of validation
2 parents 77aa12f + a4f208b commit 0f59bca
Copy full SHA for 0f59bca

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/OptionsResolver/OptionsResolver.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/OptionsResolver/OptionsResolver.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ public function resolve(array $options = array())
230230
// Resolve options
231231
$resolvedOptions = $combinedOptions->all();
232232

233-
$this->validateOptionValues($resolvedOptions);
234233
$this->validateOptionTypes($resolvedOptions);
234+
$this->validateOptionValues($resolvedOptions);
235235

236236
return $resolvedOptions;
237237
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.