Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0de35b0

Browse filesBrowse files
llupafabpot
authored andcommitted
Change ProxyCacheWarmer::warmUp signature
1 parent 4d2480c commit 0de35b0
Copy full SHA for 0de35b0

File tree

Expand file treeCollapse file tree

3 files changed

+3
-4
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-4
lines changed

‎UPGRADE-6.4.md

Copy file name to clipboardExpand all lines: UPGRADE-6.4.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ DependencyInjection
9696
DoctrineBridge
9797
--------------
9898

99+
* [BC Break] Add argument `$buildDir` to `ProxyCacheWarmer::warmUp()`
99100
* [BC Break] Add return type-hints to `EntityFactory`
100101
* Deprecate `DbalLogger`, use a middleware instead
101102
* Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder`

‎src/Symfony/Bridge/Doctrine/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ CHANGELOG
44
6.4
55
---
66

7+
* [BC BREAK] Add argument `$buildDir` to `ProxyCacheWarmer::warmUp()`
78
* [BC BREAK] Add return type-hints to `EntityFactory`
89
* Deprecate `DbalLogger`, use a middleware instead
910
* Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder`

‎src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,7 @@ public function isOptional(): bool
3737
return false;
3838
}
3939

40-
/**
41-
* @param string|null $buildDir
42-
*/
43-
public function warmUp(string $cacheDir /* , string $buildDir = null */): array
40+
public function warmUp(string $cacheDir, string $buildDir = null): array
4441
{
4542
$files = [];
4643
foreach ($this->registry->getManagers() as $em) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.