Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 0b0cbd3

Browse filesBrowse files
fabpotfabpot
committed
bug #47394 [Console] [Completion] Make bash completion run in non interactive mode (Seldaek)
This PR was merged into the 5.4 branch. Discussion ---------- [Console] [Completion] Make bash completion run in non interactive mode | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Refs composer/composer#11024 Composer does prompt in some contexts, and that blocks/freezes the completion as it runs in an interactive context but is not actually visible. Explicitly setting it to be non interactive seems to be the fix to me. TODO: - [ ] A similar fix probably should be applied to other completion types supported in newer versions than 5.4 Commits ------- cf0b56f Make bash completion run in non interactive mode
2 parents 72a3ad5 + cf0b56f commit 0b0cbd3
Copy full SHA for 0b0cbd3

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/Console/Resources/completion.bash

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Resources/completion.bash
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ _sf_{{ COMMAND_NAME }}() {
2424
local cur prev words cword
2525
_get_comp_words_by_ref -n := cur prev words cword
2626

27-
local completecmd=("$sf_cmd" "_complete" "-sbash" "-c$cword" "-S{{ VERSION }}")
27+
local completecmd=("$sf_cmd" "_complete" "--no-interaction" "-sbash" "-c$cword" "-S{{ VERSION }}")
2828
for w in ${words[@]}; do
2929
w=$(printf -- '%b' "$w")
3030
# remove quotes from typed values

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.