Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0a0f18d

Browse filesBrowse files
committed
Added more tests
1 parent 6cbb564 commit 0a0f18d
Copy full SHA for 0a0f18d

File tree

4 files changed

+35
-6
lines changed
Filter options

4 files changed

+35
-6
lines changed

‎src/Symfony/Component/Translation/Loader/XliffFileLoader.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Loader/XliffFileLoader.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,16 @@ private function extractXliff2(\DOMDocument $dom, MessageCatalogue $catalogue, $
146146
}
147147

148148
if (isset($unit->notes)) {
149-
$metadata['notes'] = [];
149+
$metadata['notes'] = array();
150150
foreach ($unit->notes->note as $noteNode) {
151-
$note = [];
151+
$note = array();
152152
foreach ($noteNode->attributes() as $key => $value) {
153153
$note[$key] = (string) $value;
154154
}
155155
$note['content'] = (string) $noteNode;
156156
$metadata['notes'][] = $note;
157157
}
158-
}
158+
}
159159

160160
$catalogue->setMetadata((string) $source, $metadata, $domain);
161161
}

‎src/Symfony/Component/Translation/Tests/Dumper/XliffFileDumperTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/Dumper/XliffFileDumperTest.php
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,17 @@ public function testFormatCatalogueWithNotesMetadata()
9393
$catalogue = new MessageCatalogue('en_US');
9494
$catalogue->add(array(
9595
'foo' => 'bar',
96+
'baz' => 'biz',
9697
));
9798
$catalogue->setMetadata('foo', array('notes' => array(
9899
array('category' => 'state', 'content' => 'new'),
99100
array('category' => 'approved', 'content' => 'true'),
100101
array('category' => 'section', 'content' => 'user login', 'priority' => '1'),
101102
)));
103+
$catalogue->setMetadata('baz', array('notes' => array(
104+
array('id' => 'x', 'content' => 'x_content'),
105+
array('appliesTo' => 'target', 'category'=>'quality', 'content' => 'Fuzzy'),
106+
)));
102107

103108
$dumper = new XliffFileDumper();
104109

‎src/Symfony/Component/Translation/Tests/Loader/XliffFileLoaderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/Loader/XliffFileLoaderTest.php
+17-3Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,15 +192,16 @@ public function testLoadVersion2()
192192
public function testLoadVersion2WithNoteMeta()
193193
{
194194
$loader = new XliffFileLoader();
195-
$resource = __DIR__.'/../fixtures/resources-notes-meta.xlf';
195+
$resource = __DIR__.'/../fixtures/resources-notes-meta.xlf';
196196
$catalogue = $loader->load($resource, 'en', 'domain1');
197197

198198
$this->assertEquals('en', $catalogue->getLocale());
199199
$this->assertEquals(array(new FileResource($resource)), $catalogue->getResources());
200200
$this->assertSame(array(), libxml_get_errors());
201201

202-
$this->assertTrue($catalogue->defines('foo'));
203-
$metadata = $catalogue->getMetadata('foo');
202+
// test for "foo" metadata
203+
$this->assertTrue($catalogue->defines('foo', 'domain1'));
204+
$metadata = $catalogue->getMetadata('foo', 'domain1');
204205
$this->assertNotEmpty($metadata);
205206
$this->assertCount(3, $metadata['notes']);
206207

@@ -213,5 +214,18 @@ public function testLoadVersion2WithNoteMeta()
213214
$this->assertEquals('section', $metadata['notes'][2]['category']);
214215
$this->assertEquals('1', $metadata['notes'][2]['priority']);
215216
$this->assertEquals('user login', $metadata['notes'][2]['content']);
217+
218+
// test for "baz" metadata
219+
$this->assertTrue($catalogue->defines('baz', 'domain1'));
220+
$metadata = $catalogue->getMetadata('baz', 'domain1');
221+
$this->assertNotEmpty($metadata);
222+
$this->assertCount(2, $metadata['notes']);
223+
224+
$this->assertEquals('x', $metadata['notes'][0]['id']);
225+
$this->assertEquals('x_content', $metadata['notes'][0]['content']);
226+
227+
$this->assertEquals('target', $metadata['notes'][1]['appliesTo']);
228+
$this->assertEquals('quality', $metadata['notes'][1]['category']);
229+
$this->assertEquals('Fuzzy', $metadata['notes'][1]['content']);
216230
}
217231
}

‎src/Symfony/Component/Translation/Tests/fixtures/resources-notes-meta.xlf

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/fixtures/resources-notes-meta.xlf
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,15 @@
1212
<target>bar</target>
1313
</segment>
1414
</unit>
15+
<unit id="uqWglk0">
16+
<notes>
17+
<note id="x">x_content</note>
18+
<note appliesTo="target" category="quality">Fuzzy</note>
19+
</notes>
20+
<segment>
21+
<source>baz</source>
22+
<target>biz</target>
23+
</segment>
24+
</unit>
1525
</file>
1626
</xliff>

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.