Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0936a4e

Browse filesBrowse files
committed
bug #35899 [DomCrawler] prevent deprecation being triggered from assertion (xabbuh)
This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler] prevent deprecation being triggered from assertion | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35889 | License | MIT | Doc PR | Commits ------- b01a10c prevent deprecation being triggered from assertion
2 parents 2bd76fa + b01a10c commit 0936a4e
Copy full SHA for 0936a4e

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed

‎src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextContains.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextContains.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ protected function matches($crawler): bool
4545
return false;
4646
}
4747

48-
return false !== mb_strpos($crawler->text(), $this->expectedText);
48+
return false !== mb_strpos($crawler->text(null, false), $this->expectedText);
4949
}
5050

5151
/**

‎src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextSame.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DomCrawler/Test/Constraint/CrawlerSelectorTextSame.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ protected function matches($crawler): bool
4545
return false;
4646
}
4747

48-
return $this->expectedText === trim($crawler->text());
48+
return $this->expectedText === trim($crawler->text(null, false));
4949
}
5050

5151
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.