Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 08b9647

Browse filesBrowse files
committed
Don't filter out zero delay
1 parent 1814ff3 commit 08b9647
Copy full SHA for 08b9647

File tree

Expand file treeCollapse file tree

2 files changed

+27
-9
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+27
-9
lines changed

‎src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ private function getWaitingTime(Envelope $envelope, \Throwable $throwable, Retry
158158
}
159159
}
160160

161-
if (\count($delays) > 0) {
162-
$delay = min(array_filter($delays));
161+
if ($delays = array_filter($delays, fn ($delay) => null !== $delay)) {
162+
$delay = min($delays);
163163
}
164164
}
165165

‎src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageForRetryListenerTest.php
+25-7Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,18 @@ public function testRecoverableExceptionRetryDelayOverridesStrategy()
109109
$listener->onMessageFailed($event);
110110
}
111111

112-
public function testWrappedRecoverableExceptionRetryDelayOverridesStrategy()
112+
/**
113+
* @dataProvider provideRetryDelays
114+
*/
115+
public function testWrappedRecoverableExceptionRetryDelayOverridesStrategy(array $retries, int $expectedDelay)
113116
{
114117
$sender = $this->createMock(SenderInterface::class);
115-
$sender->expects($this->once())->method('send')->willReturnCallback(function (Envelope $envelope) {
118+
$sender->expects($this->once())->method('send')->willReturnCallback(function (Envelope $envelope) use ($expectedDelay) {
116119
$delayStamp = $envelope->last(DelayStamp::class);
117120
$redeliveryStamp = $envelope->last(RedeliveryStamp::class);
118121

119122
$this->assertInstanceOf(DelayStamp::class, $delayStamp);
120-
$this->assertSame(1234, $delayStamp->getDelay());
123+
$this->assertSame($expectedDelay, $delayStamp->getDelay());
121124

122125
$this->assertInstanceOf(RedeliveryStamp::class, $redeliveryStamp);
123126
$this->assertSame(1, $redeliveryStamp->getRetryCount());
@@ -137,16 +140,31 @@ public function testWrappedRecoverableExceptionRetryDelayOverridesStrategy()
137140
$envelope = new Envelope(new \stdClass());
138141
$exception = new HandlerFailedException(
139142
$envelope,
140-
[
141-
new RecoverableMessageHandlingException('retry', retryDelay: 1235),
142-
new RecoverableMessageHandlingException('retry', retryDelay: 1234),
143-
]
143+
array_map(fn (int $retry) => new RecoverableMessageHandlingException('retry', retryDelay: $retry), $retries)
144144
);
145145
$event = new WorkerMessageFailedEvent($envelope, 'my_receiver', $exception);
146146

147147
$listener->onMessageFailed($event);
148148
}
149149

150+
public static function provideRetryDelays(): iterable
151+
{
152+
yield 'one_exception' => [
153+
[1235],
154+
1235,
155+
];
156+
157+
yield 'multiple_exceptions' => [
158+
[1235, 2000, 1000],
159+
1000,
160+
];
161+
162+
yield 'zero_delay' => [
163+
[0, 2000, 1000],
164+
0,
165+
];
166+
}
167+
150168
public function testEnvelopeIsSentToTransportOnRetry()
151169
{
152170
$exception = new \Exception('no!');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.