Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 06e7458

Browse filesBrowse files
bug #34198 [HttpClient] Fix perf issue when doing thousands of requests with curl (nicolas-grekas)
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Fix perf issue when doing thousands of requests with curl | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Performing while scheduling requests was a terrible idea: it makes buffers fill in memory and requires CPU do deal with the pending list, while all this in dealt with much more efficiently by any response-reading code that comes after. Commits ------- e388b73 [HttpClient] Fix perf issue when doing thousands of requests with curl
2 parents e8b31ff + e388b73 commit 06e7458
Copy full SHA for 06e7458

File tree

1 file changed

+0
-1
lines changed
Filter options

1 file changed

+0
-1
lines changed

‎src/Symfony/Component/HttpClient/Response/CurlResponse.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpClient/Response/CurlResponse.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ public function __construct(CurlClientState $multi, $ch, array $options = null,
142142
// Schedule the request in a non-blocking way
143143
$multi->openHandles[$id] = [$ch, $options];
144144
curl_multi_add_handle($multi->handle, $ch);
145-
self::perform($multi);
146145
}
147146

148147
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.