Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 063e880

Browse filesBrowse files
committed
[PropertyInfo] add static cache to ContextFactory
ContextFactory::createFromReflector is heavy, and it's called redundanlty by Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor for each property and methods. Avoid that by parsing it only once and then use static cache
1 parent f0a6675 commit 063e880
Copy full SHA for 063e880

File tree

1 file changed

+24
-2
lines changed
Filter options

1 file changed

+24
-2
lines changed

‎src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php
+24-2Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use phpDocumentor\Reflection\DocBlock;
1515
use phpDocumentor\Reflection\DocBlockFactory;
1616
use phpDocumentor\Reflection\DocBlockFactoryInterface;
17+
use phpDocumentor\Reflection\Types\Context;
1718
use phpDocumentor\Reflection\Types\ContextFactory;
1819
use Symfony\Component\PropertyInfo\PropertyDescriptionExtractorInterface;
1920
use Symfony\Component\PropertyInfo\PropertyTypeExtractorInterface;
@@ -38,6 +39,11 @@ class PhpDocExtractor implements PropertyDescriptionExtractorInterface, Property
3839
*/
3940
private $docBlocks = [];
4041

42+
/**
43+
* @var Context[]
44+
*/
45+
private $contexts = [];
46+
4147
private $docBlockFactory;
4248
private $contextFactory;
4349
private $phpDocTypeHelper;
@@ -191,7 +197,7 @@ private function getDocBlockFromProperty(string $class, string $property): ?DocB
191197
}
192198

193199
try {
194-
return $this->docBlockFactory->create($reflectionProperty, $this->contextFactory->createFromReflector($reflectionProperty->getDeclaringClass()));
200+
return $this->docBlockFactory->create($reflectionProperty, $this->createFromReflector($reflectionProperty->getDeclaringClass()));
195201
} catch (\InvalidArgumentException $e) {
196202
return null;
197203
}
@@ -227,9 +233,25 @@ private function getDocBlockFromMethod(string $class, string $ucFirstProperty, i
227233
}
228234

229235
try {
230-
return [$this->docBlockFactory->create($reflectionMethod, $this->contextFactory->createFromReflector($reflectionMethod)), $prefix];
236+
return [$this->docBlockFactory->create($reflectionMethod, $this->createFromReflector($reflectionMethod->getDeclaringClass())), $prefix];
231237
} catch (\InvalidArgumentException $e) {
232238
return null;
233239
}
234240
}
241+
242+
/**
243+
* Prevents a lot of redundant calls to ContextFactory::createForNamespace().
244+
*/
245+
private function createFromReflector(\ReflectionClass $reflector): Context
246+
{
247+
$cacheKey = $reflector->getNamespaceName().':'.$reflector->getFileName();
248+
249+
if (isset($this->contexts[$cacheKey])) {
250+
return $this->contexts[$cacheKey];
251+
}
252+
253+
$this->contexts[$cacheKey] = $this->contextFactory->createFromReflector($reflector);
254+
255+
return $this->contexts[$cacheKey];
256+
}
235257
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.