Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 05c76bb

Browse filesBrowse files
committed
Fix serializer do not transform empty \Traversable to Array
1 parent 0506f8c commit 05c76bb
Copy full SHA for 05c76bb

File tree

2 files changed

+19
-0
lines changed
Filter options

2 files changed

+19
-0
lines changed

‎src/Symfony/Component/Serializer/Serializer.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Serializer.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,10 @@ public function normalize($data, $format = null, array $context = [])
157157
}
158158

159159
if (\is_array($data) || $data instanceof \Traversable) {
160+
if ($data instanceof \Countable && 0 === $data->count()) {
161+
return $data;
162+
}
163+
160164
$normalized = [];
161165
foreach ($data as $key => $val) {
162166
$normalized[$key] = $this->normalize($val, $format, $context);

‎src/Symfony/Component/Serializer/Tests/SerializerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Tests/SerializerTest.php
+15Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
2626
use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface;
2727
use Symfony\Component\Serializer\Mapping\Loader\AnnotationLoader;
28+
use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
2829
use Symfony\Component\Serializer\Normalizer\ArrayDenormalizer;
2930
use Symfony\Component\Serializer\Normalizer\CustomNormalizer;
3031
use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
@@ -490,6 +491,20 @@ public function testNotNormalizableValueExceptionMessageForAResource()
490491
(new Serializer())->normalize(tmpfile());
491492
}
492493

494+
public function testNormalizePreserveEmptyArrayObject()
495+
{
496+
$serializer = new Serializer([
497+
new PropertyNormalizer(),
498+
new ObjectNormalizer(),
499+
new ArrayDenormalizer()], ['json' => new JsonEncoder()]);
500+
501+
$object = [];
502+
$object['foo'] = new \ArrayObject();
503+
$object['bar'] = new \ArrayObject(['notempty']);
504+
$object['baz'] = new \ArrayObject(['nested' => new \ArrayObject()]);
505+
$this->assertEquals('{"foo":{},"bar":["notempty"],"baz":{"nested":{}}}', $serializer->serialize($object, 'json', [AbstractObjectNormalizer::PRESERVE_EMPTY_OBJECTS => true]));
506+
}
507+
493508
private function serializerWithClassDiscriminator()
494509
{
495510
$classMetadataFactory = new ClassMetadataFactory(new AnnotationLoader(new AnnotationReader()));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.