Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 02076e0

Browse filesBrowse files
committed
[FrameworkBundle] Fixed form type extensions priority ordering
1 parent 93a00b0 commit 02076e0
Copy full SHA for 02076e0

File tree

1 file changed

+16
-8
lines changed
Filter options
  • src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler

1 file changed

+16
-8
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/FormPass.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/FormPass.php
+16-8Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler;
1313

14-
use Symfony\Component\DependencyInjection\Compiler\PriorityTaggedServiceTrait;
1514
use Symfony\Component\DependencyInjection\ContainerBuilder;
1615
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
1716
use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
@@ -24,8 +23,6 @@
2423
*/
2524
class FormPass implements CompilerPassInterface
2625
{
27-
use PriorityTaggedServiceTrait;
28-
2926
public function process(ContainerBuilder $container)
3027
{
3128
if (!$container->hasDefinition('form.extension')) {
@@ -49,23 +46,34 @@ public function process(ContainerBuilder $container)
4946

5047
$definition->replaceArgument(1, $types);
5148

52-
$typeExtensions = array();
49+
$typeExtensionsToSort = array();
5350

54-
foreach ($this->findAndSortTaggedServices('form.type_extension', $container) as $reference) {
55-
$serviceId = (string) $reference;
51+
foreach ($container->findTaggedServiceIds('form.type_extension') as $serviceId => $tag) {
5652
$serviceDefinition = $container->getDefinition($serviceId);
5753
if (!$serviceDefinition->isPublic()) {
5854
throw new InvalidArgumentException(sprintf('The service "%s" must be public as form type extensions are lazy-loaded.', $serviceId));
5955
}
6056

61-
$tag = $serviceDefinition->getTag('form.type_extension');
6257
if (isset($tag[0]['extended_type'])) {
6358
$extendedType = $tag[0]['extended_type'];
6459
} else {
6560
throw new InvalidArgumentException(sprintf('Tagged form type extension must have the extended type configured using the extended_type/extended-type attribute, none was configured for the "%s" service.', $serviceId));
6661
}
6762

68-
$typeExtensions[$extendedType][] = $serviceId;
63+
$typeExtensionsToSort[isset($tag[0]['priority']) ? $tag[0]['priority'] : 0][] = array(
64+
'service_id' => $serviceId,
65+
'extended_type' => $extendedType,
66+
);
67+
}
68+
69+
$typeExtensions = array();
70+
if ($typeExtensionsToSort) {
71+
krsort($typeExtensionsToSort);
72+
$typeExtensionsSorted = call_user_func_array('array_merge', $typeExtensionsToSort);
73+
74+
foreach ($typeExtensionsSorted as $typeExtension) {
75+
$typeExtensions[$typeExtension['extended_type']][] = $typeExtension['service_id'];
76+
}
6977
}
7078

7179
$definition->replaceArgument(2, $typeExtensions);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.