Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/slack-notifier
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.6
Choose a base ref
Loading
...
head repository: symfony/slack-notifier
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.2.0-BETA1
Choose a head ref
Loading
  • 11 commits
  • 14 files changed
  • 6 contributors

Commits on May 31, 2024

  1. [Notifier] [Slack] Add button block element and emoji/verbatim op…

    …tions to section block
    cvergne authored and fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    62089f4 View commit details
    Browse the repository at this point in the history
  2. feature #54737 [Notifier] [Slack] Add button block element and `emoji…

    …`/`verbatim` options to section block (cvergne)
    
    This PR was squashed before being merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [Notifier] [Slack] Add button block element and `emoji`/`verbatim` options to section block
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Issues        | -
    | License       | MIT
    
    Hi,
    
    When using the Slack Notifier bridge, I've noticed it wasn't possible to add a button as accessory to a section because button is only managed in the SlackActionsBlock, which is not allowed as an accessory in a Section block.
    So the first purpose of this PR is add a SlackButtonBlockElement we can use as `accessory` into a section block (and use that block into SlackActionsBlock as it follows the same structure).
    
    Then, I noticed `verbatim` (for markdown) and `emoji` (for plain text) options were not available in SectionBlock (but available in ContextBlock), so I've added them.
    Note that originally, I was going to add them as optional arguments (`?bool $verbatim = null`) to avoid adding them if not explicitly given and keep the Slack default value, but the ContextBlock adds a default value (the same as Slack) for them, so I kept the same argument signature.
    
    You can see an example of both use of button as accessory and verbatim param with the following link on [Slack Block Kit Builder](https://app.slack.com/block-kit-builder/#%7B%22blocks%22:%5B%7B%22type%22:%22section%22,%22text%22:%7B%22type%22:%22mrkdwn%22,%22text%22:%22Example%20with%20URL%20:%20Symfony.com%22,%22verbatim%22:true%7D,%22accessory%22:%7B%22type%22:%22button%22,%22text%22:%7B%22type%22:%22plain_text%22,%22emoji%22:true,%22text%22:%22Button%20as%20accessory%22%7D,%22value%22:%22https://symfony.com%22%7D%7D,%7B%22type%22:%22context%22,%22elements%22:%5B%7B%22type%22:%22mrkdwn%22,%22text%22:%22from%20*Symfony.com*%22,%22verbatim%22:true%7D%5D%7D%5D%7D) (_must be logged in to a Slack Account_).
    
    _These minor additions are in the same PR, but tell me if I should split them into two PRs._
    
    Thanks :)
    
    Commits
    -------
    
    e9b79542a3 [Notifier] [Slack] Add button block element and `emoji`/`verbatim` options to section block
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8607c3a View commit details
    Browse the repository at this point in the history
  3. [Notifier] [Slack] Add README examples about button block element and…

    … emoji/verbatim options to section block
    cvergne committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ec1fa02 View commit details
    Browse the repository at this point in the history
  4. Merge branch '7.1' into 7.2

    * 7.1:
      Remove subtree split checks
      Remove subtree split checks
      Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)"
      [SecurityBundle] Fix `container.build_hash` parameter binding
      [Serializer] Fix denormalizing a collection of union types
      [DoctrineBridge] Fix `UniqueEntityValidator` with proxy object
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ce28975 View commit details
    Browse the repository at this point in the history
  5. minor #57271 [Notifier] [Slack] Add README examples about button bloc…

    …k element and emoji/verbatim options (cvergne)
    
    This PR was merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [Notifier] [Slack] Add README examples about button block element and emoji/verbatim options
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix symfony/symfony-docs#19929
    | License       | MIT
    
    This PR is just a followup of my previously merged PR symfony/symfony#54737.
    Following the merge, [an issue was created about documentation](symfony/symfony-docs#19929), but each Notifier Bridge documentation is directly in README of each bridge so here it is :)
    
    Commits
    -------
    
    1a52e8717f [Notifier] [Slack] Add README examples about button block element and emoji/verbatim options to section block
    fabpot committed May 31, 2024
    Configuration menu
    Copy the full SHA
    64e09fe View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Prefix all sprintf() calls

    derrabus committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    09d11a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Update .gitattributes

    fabpot committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6cbb6f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    afcdbe9 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    d810594 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch '7.1' into 7.2

    * 7.1:
      Add PR template and auto-close PR on subtree split repositories
    nicolas-grekas committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4032dd9 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xab…

    …buh)
    
    This PR was merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [Notifier] deprecate the TransportFactoryTestCase
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | yes
    | Issues        | Fix #54100
    | License       | MIT
    
    Commits
    -------
    
    c8b0fcc77b deprecate the TransportFactoryTestCase
    fabpot committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    802d7ae View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.