-
-
Notifications
You must be signed in to change notification settings - Fork 13
Comparing changes
Open a pull request
base repository: symfony/slack-notifier
base: v7.1.6
head repository: symfony/slack-notifier
compare: v7.2.0-BETA1
- 11 commits
- 14 files changed
- 6 contributors
Commits on May 31, 2024
-
[Notifier] [Slack] Add button block element and
emoji
/verbatim
op……tions to section block
Configuration menu - View commit details
-
Copy full SHA for 62089f4 - Browse repository at this point
Copy the full SHA 62089f4View commit details -
feature #54737 [Notifier] [Slack] Add button block element and `emoji…
…`/`verbatim` options to section block (cvergne) This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Notifier] [Slack] Add button block element and `emoji`/`verbatim` options to section block | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Hi, When using the Slack Notifier bridge, I've noticed it wasn't possible to add a button as accessory to a section because button is only managed in the SlackActionsBlock, which is not allowed as an accessory in a Section block. So the first purpose of this PR is add a SlackButtonBlockElement we can use as `accessory` into a section block (and use that block into SlackActionsBlock as it follows the same structure). Then, I noticed `verbatim` (for markdown) and `emoji` (for plain text) options were not available in SectionBlock (but available in ContextBlock), so I've added them. Note that originally, I was going to add them as optional arguments (`?bool $verbatim = null`) to avoid adding them if not explicitly given and keep the Slack default value, but the ContextBlock adds a default value (the same as Slack) for them, so I kept the same argument signature. You can see an example of both use of button as accessory and verbatim param with the following link on [Slack Block Kit Builder](https://app.slack.com/block-kit-builder/#%7B%22blocks%22:%5B%7B%22type%22:%22section%22,%22text%22:%7B%22type%22:%22mrkdwn%22,%22text%22:%22Example%20with%20URL%20:%20Symfony.com%22,%22verbatim%22:true%7D,%22accessory%22:%7B%22type%22:%22button%22,%22text%22:%7B%22type%22:%22plain_text%22,%22emoji%22:true,%22text%22:%22Button%20as%20accessory%22%7D,%22value%22:%22https://symfony.com%22%7D%7D,%7B%22type%22:%22context%22,%22elements%22:%5B%7B%22type%22:%22mrkdwn%22,%22text%22:%22from%20*Symfony.com*%22,%22verbatim%22:true%7D%5D%7D%5D%7D) (_must be logged in to a Slack Account_). _These minor additions are in the same PR, but tell me if I should split them into two PRs._ Thanks :) Commits ------- e9b79542a3 [Notifier] [Slack] Add button block element and `emoji`/`verbatim` options to section block
Configuration menu - View commit details
-
Copy full SHA for 8607c3a - Browse repository at this point
Copy the full SHA 8607c3aView commit details -
[Notifier] [Slack] Add README examples about button block element and…
… emoji/verbatim options to section block
Configuration menu - View commit details
-
Copy full SHA for ec1fa02 - Browse repository at this point
Copy the full SHA ec1fa02View commit details -
* 7.1: Remove subtree split checks Remove subtree split checks Revert "minor #54653 Auto-close PRs on subtree-splits (nicolas-grekas)" [SecurityBundle] Fix `container.build_hash` parameter binding [Serializer] Fix denormalizing a collection of union types [DoctrineBridge] Fix `UniqueEntityValidator` with proxy object
Configuration menu - View commit details
-
Copy full SHA for ce28975 - Browse repository at this point
Copy the full SHA ce28975View commit details -
minor #57271 [Notifier] [Slack] Add README examples about button bloc…
…k element and emoji/verbatim options (cvergne) This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] [Slack] Add README examples about button block element and emoji/verbatim options | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony-docs#19929 | License | MIT This PR is just a followup of my previously merged PR symfony/symfony#54737. Following the merge, [an issue was created about documentation](symfony/symfony-docs#19929), but each Notifier Bridge documentation is directly in README of each bridge so here it is :) Commits ------- 1a52e8717f [Notifier] [Slack] Add README examples about button block element and emoji/verbatim options to section block
Configuration menu - View commit details
-
Copy full SHA for 64e09fe - Browse repository at this point
Copy the full SHA 64e09feView commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 09d11a1 - Browse repository at this point
Copy the full SHA 09d11a1View commit details
Commits on Jul 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6cbb6f9 - Browse repository at this point
Copy the full SHA 6cbb6f9View commit details
Commits on Jul 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for afcdbe9 - Browse repository at this point
Copy the full SHA afcdbe9View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d810594 - Browse repository at this point
Copy the full SHA d810594View commit details
Commits on Sep 25, 2024
-
* 7.1: Add PR template and auto-close PR on subtree split repositories
Configuration menu - View commit details
-
Copy full SHA for 4032dd9 - Browse repository at this point
Copy the full SHA 4032dd9View commit details
Commits on Sep 27, 2024
-
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xab…
…buh) This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] deprecate the TransportFactoryTestCase | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #54100 | License | MIT Commits ------- c8b0fcc77b deprecate the TransportFactoryTestCase
Configuration menu - View commit details
-
Copy full SHA for 802d7ae - Browse repository at this point
Copy the full SHA 802d7aeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v7.1.6...v7.2.0-BETA1