checking for .env file exists instead of using the env variable #176
Conversation
|
We also need to make a change in Flex, as it would copy the |
|
I'm very much against this change. It's a question of precedence and I don't want to change it. It's consistent with the behavior of other frameworks and we/I take advantage of this property in many projects. What we could do instead is having a CLI tool that list defined env vars and tell the dev where they are coming from (env var, .env, $_SERVER, ...). |
|
Hmm. Ok. Then we'll solve it in other ways - i.e. finding ways to be a bit more verbose about where environment vars are coming from, or if the |
Hi guys!
This comes from a workshop I gave last week. One user - from using Laravel - already had an
APP_ENVenvironment variable defined in their VM. Because of this, their.envfile was being completely ignored, which was difficult to track down.I think it's much simpler if we require the
.envfile simply if it exists. If you agree, there's one other change to make (https://github.com/symfony/flex/blob/d68d28624e3ec972d6887cca06f7df5e07ba03a9/src/Configurator/MakefileConfigurator.php#L34), which I can do.Cheers!