This is not valid. The arguments need to be different for V7 or v8 (see just above where we already detect version 8+ for other differences)

Like I said in the ticket, this applies to both v7 and v8. ClientBuilder::fromConfig works the same in both versions by proxying to the set* method and the only such method that exists is setHosts, not setHost.

In my demo project I just ran composer require elasticsearch/elasticsearch=^7 (using Elastica, so no v8), then set the monolog config like:

  monolog:
    handlers:
      main:
        type: fingers_crossed
        handler: elastic_search
        action_level: error
        excluded_http_codes: [404, 405]
        buffer_size: 50
      elastic_search:
        type: elastic_search
        elasticsearch:
          host: '%elastic_domain%'
          port: '%elastic_port%'
        index: '%elastic_index_monolog%'

Finally, I ran ./bin/console cache:clear (after rm -rf var/cache/* for good measure). And it also fails with:

In ClientBuilder.php line 217:

  Unknown parameters provided: host  

So far as I can tell this has always been the case in that client (though I only checked to v5). I think we just accidentally assumed the parameter was the same as Elastica at the time of implementation.

You are correct when it comes to Elastica, though, which I noted here.

@stof Bump!

(Let me know if y'all don't like bumps.)

Looking at the method ClientBuilder::fromConfig of all versions of elasticsearch-php, I see that the parameter has always been the plural hosts. This update looks good to me.

The PR needs to be rebased on 3.x.