Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b958e68

Browse filesBrowse files
[Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers
1 parent b84032b commit b958e68
Copy full SHA for b958e68

File tree

Expand file treeCollapse file tree

2 files changed

+8
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-4
lines changed

‎Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php

Copy file name to clipboardExpand all lines: Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
+7-3Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,16 @@ public function reverseTransform($value)
122122
$value = str_replace(',', $decSep, $value);
123123
}
124124

125-
if (!strstr($value, $decSep) && PHP_INT_SIZE === 8) {
126-
$result = $formatter->parse($value, \NumberFormatter::TYPE_INT64, $position);
125+
if (false !== strpos($value, $decSep)) {
126+
$type = \NumberFormatter::TYPE_DOUBLE;
127127
} else {
128-
$result = $formatter->parse($value, \NumberFormatter::TYPE_DOUBLE, $position);
128+
$type = PHP_INT_SIZE === 8
129+
? \NumberFormatter::TYPE_INT64
130+
: \NumberFormatter::TYPE_INT32;
129131
}
130132

133+
$result = $formatter->parse($value, $type, $position);
134+
131135
if (intl_is_failure($formatter->getErrorCode())) {
132136
throw new TransformationFailedException($formatter->getErrorMessage());
133137
}

‎Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php

Copy file name to clipboardExpand all lines: Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,6 @@ public function testReverseTransformBigint()
438438
{
439439
$transformer = new NumberToLocalizedStringTransformer(null, true);
440440

441-
$this->assertEquals(401657096594165125, (int) $transformer->reverseTransform((string) 401657096594165125));
441+
$this->assertEquals(PHP_INT_MAX - 1, (int) $transformer->reverseTransform((string) (PHP_INT_MAX - 1)));
442442
}
443443
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.