Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 30108d5

Browse filesBrowse files
xabbuhxabbuh
committed
replace assertEmpty() with stricter assertions
1 parent 4782c6f commit 30108d5
Copy full SHA for 30108d5

File tree

Expand file treeCollapse file tree

7 files changed

+18
-18
lines changed
Filter options
Expand file treeCollapse file tree

7 files changed

+18
-18
lines changed

‎Tests/Compiler/DecoratorServicePassTest.php

Copy file name to clipboardExpand all lines: Tests/Compiler/DecoratorServicePassTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio
197197

198198
$this->process($container);
199199

200-
$this->assertEmpty($container->getDefinition('baz.inner')->getTags());
200+
$this->assertSame([], $container->getDefinition('baz.inner')->getTags());
201201
$this->assertEquals(['bar' => ['attr' => 'baz'], 'foobar' => ['attr' => 'bar'], 'container.decorator' => [['id' => 'foo', 'inner' => 'baz.inner']]], $container->getDefinition('baz')->getTags());
202202
}
203203

@@ -220,7 +220,7 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio
220220

221221
$this->process($container);
222222

223-
$this->assertEmpty($container->getDefinition('deco1')->getTags());
223+
$this->assertSame([], $container->getDefinition('deco1')->getTags());
224224
$this->assertEquals(['bar' => ['attr' => 'baz'], 'container.decorator' => [['id' => 'foo', 'inner' => 'deco1.inner']]], $container->getDefinition('deco2')->getTags());
225225
}
226226

‎Tests/Compiler/PassConfigTest.php

Copy file name to clipboardExpand all lines: Tests/Compiler/PassConfigTest.php
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ public function testPassOrderingWithoutPasses()
4545
$config->setOptimizationPasses([]);
4646
$config->setRemovingPasses([]);
4747

48-
$this->assertEmpty($config->getBeforeOptimizationPasses());
49-
$this->assertEmpty($config->getAfterRemovingPasses());
50-
$this->assertEmpty($config->getBeforeRemovingPasses());
51-
$this->assertEmpty($config->getOptimizationPasses());
52-
$this->assertEmpty($config->getRemovingPasses());
48+
$this->assertSame([], $config->getBeforeOptimizationPasses());
49+
$this->assertSame([], $config->getAfterRemovingPasses());
50+
$this->assertSame([], $config->getBeforeRemovingPasses());
51+
$this->assertSame([], $config->getOptimizationPasses());
52+
$this->assertSame([], $config->getRemovingPasses());
5353
}
5454
}

‎Tests/Compiler/ResolveInstanceofConditionalsPassTest.php

Copy file name to clipboardExpand all lines: Tests/Compiler/ResolveInstanceofConditionalsPassTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function testProcess()
3939

4040
$parent = '.instanceof.'.parent::class.'.0.foo';
4141
$def = $container->getDefinition('foo');
42-
$this->assertEmpty($def->getInstanceofConditionals());
42+
$this->assertSame([], $def->getInstanceofConditionals());
4343
$this->assertInstanceOf(ChildDefinition::class, $def);
4444
$this->assertTrue($def->isAutowired());
4545
$this->assertSame($parent, $def->getParent());
@@ -266,10 +266,10 @@ public function testMergeReset()
266266

267267
$abstract = $container->getDefinition('.abstract.instanceof.bar');
268268

269-
$this->assertEmpty($abstract->getArguments());
270-
$this->assertEmpty($abstract->getMethodCalls());
269+
$this->assertSame([], $abstract->getArguments());
270+
$this->assertSame([], $abstract->getMethodCalls());
271271
$this->assertNull($abstract->getDecoratedService());
272-
$this->assertEmpty($abstract->getTags());
272+
$this->assertSame([], $abstract->getTags());
273273
$this->assertTrue($abstract->isAbstract());
274274
}
275275

‎Tests/ContainerBuilderTest.php

Copy file name to clipboardExpand all lines: Tests/ContainerBuilderTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1150,7 +1150,7 @@ public function testAddObjectResource()
11501150
$container->setResourceTracking(false);
11511151
$container->addObjectResource(new \BarClass());
11521152

1153-
$this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
1153+
$this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
11541154

11551155
$container->setResourceTracking(true);
11561156
$container->addObjectResource(new \BarClass());
@@ -1173,7 +1173,7 @@ public function testGetReflectionClass()
11731173
$container->setResourceTracking(false);
11741174
$r1 = $container->getReflectionClass('BarClass');
11751175

1176-
$this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
1176+
$this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
11771177

11781178
$container->setResourceTracking(true);
11791179
$r2 = $container->getReflectionClass('BarClass');
@@ -1213,7 +1213,7 @@ public function testCompilesClassDefinitionsOfLazyServices()
12131213
{
12141214
$container = new ContainerBuilder();
12151215

1216-
$this->assertEmpty($container->getResources(), 'No resources get registered without resource tracking');
1216+
$this->assertSame([], $container->getResources(), 'No resources get registered without resource tracking');
12171217

12181218
$container->register('foo', 'BarClass')->setPublic(true);
12191219
$container->getDefinition('foo')->setLazy(true);
@@ -1372,7 +1372,7 @@ public function testExtensionConfig()
13721372
$container = new ContainerBuilder();
13731373

13741374
$configs = $container->getExtensionConfig('foo');
1375-
$this->assertEmpty($configs);
1375+
$this->assertSame([], $configs);
13761376

13771377
$first = ['foo' => 'bar'];
13781378
$container->prependExtensionConfig('foo', $first);

‎Tests/Dumper/PhpDumperTest.php

Copy file name to clipboardExpand all lines: Tests/Dumper/PhpDumperTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,7 +986,7 @@ public function testLazyArgumentProvideGenerator()
986986
}
987987
}
988988

989-
$this->assertEmpty(iterator_to_array($lazyContext->lazyEmptyValues));
989+
$this->assertSame([], iterator_to_array($lazyContext->lazyEmptyValues));
990990
}
991991

992992
public function testNormalizedId()

‎Tests/Loader/YamlFileLoaderTest.php

Copy file name to clipboardExpand all lines: Tests/Loader/YamlFileLoaderTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ public function testAnonymousServicesInInstanceof()
850850
$anonymous = $container->getDefinition((string) $args['foo']);
851851
$this->assertEquals('Anonymous', $anonymous->getClass());
852852
$this->assertFalse($anonymous->isPublic());
853-
$this->assertEmpty($anonymous->getInstanceofConditionals());
853+
$this->assertSame([], $anonymous->getInstanceofConditionals());
854854

855855
$this->assertFalse($container->has('Bar'));
856856
}

‎Tests/ParameterBag/EnvPlaceholderParameterBagTest.php

Copy file name to clipboardExpand all lines: Tests/ParameterBag/EnvPlaceholderParameterBagTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public function testMergeWhereFirstBagIsEmptyWillWork()
6666
// initialize placeholder only in second bag
6767
$secondBag->get($parameter);
6868

69-
$this->assertEmpty($firstBag->getEnvPlaceholders());
69+
$this->assertSame([], $firstBag->getEnvPlaceholders());
7070

7171
$firstBag->mergeEnvPlaceholders($secondBag);
7272
$mergedPlaceholders = $firstBag->getEnvPlaceholders();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.