Add is_final_step under processing/training/lambda/function step #3
Open
Rosie-Chenyr wants to merge 1 commit intosvia3:yarou-devsvia3/sagemaker-python-sdk:yarou-devfrom
Open
Add is_final_step under processing/training/lambda/function step #3Rosie-Chenyr wants to merge 1 commit intosvia3:yarou-devsvia3/sagemaker-python-sdk:yarou-devfrom
Rosie-Chenyr wants to merge 1 commit intosvia3:yarou-devsvia3/sagemaker-python-sdk:yarou-devfrom
Conversation
…unit test that the value of is_final_step can be transferred into json when defined
3ee34cd to
5eaf7e7
Compare
svia3
approved these changes
Aug 22, 2024
| """Gets the request structure for workflow service calls.""" | ||
| request_dict = super().to_request() | ||
|
|
||
| if self.is_final_step: |
Owner
There was a problem hiding this comment.
I dont see any unit tests using the @step wrapper that hits this section of code. FunctionSteps are created when users use this annotation. Did we test this / plan to test it? My intuition is that this won't work as they have a different critical path.
Author
There was a problem hiding this comment.
The unit test using the @step decorator is in tests/unit/sagemaker/workflow/test_function_step.py, where I used a current case and defined the value of is_final_step as true and test its result after the step is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add is_final_step under processing/training/lambda/function step
Testing done:
Unit test that the value of is_final_step can be transferred into json when defined
General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.