Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: cleanup event handlers on media elements #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

fix: cleanup event handlers on media elements #16005

merged 2 commits into from
May 26, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented May 26, 2025 •
edited
Loading

Fixes #14245 - this is FF-only problem because when canplay fires, the video element is still connected to the DOM in Chrome, but already detached in FF. REPL

Looks like just removing the listeners in the teardown is enough. But I'm not sure whether there are more timing-tricky cases.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-16005-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16005

dummdidumm
dummdidumm approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

packages/svelte/src/internal/client/dom/elements/events.js Show resolved Hide resolved
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: 95a7cd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti merged commit 94a2bca into sveltejs:main May 26, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request May 26, 2025
Merged
@7nik 7nik deleted the fix-14245 branch May 26, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oncanplay event called after video element is removed
3 participants
@7nik @dummdidumm @paoloricciuti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.