chore: simplify <pre>
cleaning
#15980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was looking into how we can make fewer things in #15538 need to be aware of the templating mode (which will make everything more robust) and ran into this
<pre>
logic. Took me a while to wrap my head round it but it turns out we way overcomplicated things in #14922 — the essence of this logic is that if the first node inside a<pre>
is a single newline, we need to strip it because otherwise hydration breaks:Instead of doing a convoluted song and dance we can just express that directly. For #15538, we do want to strip any remaining leading newline, but that should happen in
template_to_functions
, not here