-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
docs(blog): Introducing Runes - mention .svelte.js suffix #11522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@@ -115,6 +120,7 @@ This works, but it's pretty weird! We've found that the store API can get rather | ||
With runes, things get much simpler: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to mention .svelte.js
in prose, it should be somewhere around here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about now?
Co-authored-by: Rich Harris <rich.harris@vercel.com>
@@ -143,6 +151,8 @@ export function createCounter() { | ||
</button> | ||
``` | ||
|
||
> Runes can only be used in `.svelte.js` and `.svelte.ts` files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of Rich's (and my) suggestion here was that we should also mention .svelte
files. It's confusing to say runes only work in .svelte.js
and .svelte.ts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the new language? I didn't wanna put .svelte
, '.svelte.js' and .svelte.ts
all together, too many svelte's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It's already implied it works in .svelte files)
Co-authored-by: Rich Harris <rich.harris@vercel.com>
It was pointed out in discord that "Introducing Runes" post doesn't specify .svelte.js/ts suffix, hence this fixes that.
Also ad file names to the counter example, so first example shows counter.js, after the diff it shoes counter.svelte.js