Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs(blog): Introducing Runes - mention .svelte.js suffix #11522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 9, 2024

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented May 9, 2024

It was pointed out in discord that "Introducing Runes" post doesn't specify .svelte.js/ts suffix, hence this fixes that.

Also ad file names to the counter example, so first example shows counter.js, after the diff it shoes counter.svelte.js

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 06046a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

documentation/blog/2023-09-20-runes.md Outdated Show resolved Hide resolved
@@ -115,6 +120,7 @@ This works, but it's pretty weird! We've found that the store API can get rather
With runes, things get much simpler:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to mention .svelte.js in prose, it should be somewhere around here instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

documentation/blog/2023-09-20-runes.md Outdated Show resolved Hide resolved
documentation/blog/2023-09-20-runes.md Outdated Show resolved Hide resolved
PuruVJ and others added 2 commits May 9, 2024 22:10
Co-authored-by: Rich Harris <rich.harris@vercel.com>
@@ -143,6 +151,8 @@ export function createCounter() {
</button>
```

> Runes can only be used in `.svelte.js` and `.svelte.ts` files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of Rich's (and my) suggestion here was that we should also mention .svelte files. It's confusing to say runes only work in .svelte.js and .svelte.ts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the new language? I didn't wanna put .svelte, '.svelte.js' and .svelte.ts all together, too many svelte's

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It's already implied it works in .svelte files)

documentation/blog/2023-09-20-runes.md Outdated Show resolved Hide resolved
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.