Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Oct 26, 2023

Summary

This PR changes setup.py so that inline type annotations are enabled for the stripe-python package. Up until now, the type annotations were just hanging out, existing, but would not be analyzed by type checkers without special effort. Now, anybody who does pip install stripe will experience the inline types. (subject to the resolution order).

See more at the wiki page.

@richardm-stripe richardm-stripe requested review from a team and anniel-stripe and removed request for a team October 26, 2023 21:31
Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description for this one?

@richardm-stripe richardm-stripe enabled auto-merge (squash) October 27, 2023 00:59
@richardm-stripe richardm-stripe removed the request for review from anniel-stripe October 27, 2023 01:02
@richardm-stripe richardm-stripe merged commit 40bd8d4 into master Oct 27, 2023
@richardm-stripe richardm-stripe deleted the richardm-include-py-typed branch October 27, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.