Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

if DHCP fails the static IP can be applied without problem #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 11, 2022

Conversation

Solairseir
Copy link
Contributor

when DHCP fails the static IP can be applied without problem
adding timeout to client connection

@fpistm fpistm requested a review from ABOSTM February 28, 2022 14:24
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless timeout to be removed, otherwise, LGTM

src/EthernetClient.cpp Outdated Show resolved Hide resolved
@fpistm fpistm added this to the 12.x milestone Mar 1, 2022
@fpistm fpistm added the enhancement New feature or request label Mar 1, 2022
Co-authored-by: Alexandre Bourdiol <50730894+ABOSTM@users.noreply.github.com>
src/EthernetClient.cpp Outdated Show resolved Hide resolved
@fpistm fpistm merged commit d5993db into stm32duino:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.