Allow JSONArray constructor that takes object collections to take collections of any kind #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lections of any kind. Trying to build a new JSONArray from a Collection<E> (where E != Object) throws an exception because it uses another constructor that takes an Object as argument which is supposed to be an array.
Author
|
I just noticed that a similar pull request has been closed. Updating the JSON library from a version without generics (before may 6th 2014!) broke our code because Collection (for instance) is a subtype of Collection, but not of Collection. |
Owner
|
Please continue this discussion in #153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build a new JSONArray from a Collection (where E != Object) throws an exception because it uses another constructor that takes an Object as argument which is supposed to be an array.