Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Save/restore default locale in test #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stleary merged 1 commit into from
Dec 30, 2025
Merged

Save/restore default locale in test #1027

stleary merged 1 commit into from
Dec 30, 2025

Conversation

@Simulant87
Copy link
Contributor

@Simulant87 Simulant87 commented Dec 20, 2025

fixes #1023

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stleary stleary changed the title save and restore the current default locale, to avoid any side effects Save/restore default locale in test Dec 25, 2025
@stleary
Copy link
Owner

stleary commented Dec 25, 2025

What problem does this code solve?
Changing the default locale could affect other workflows. Save and restore the default for other maven tests.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, it fixes a test that leaks a locale change

Was any code refactored in this commit?
No

Review status

APPROVED

Starting 3-day comment window

@stleary stleary merged commit e635f40 into stleary:master Dec 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stleary stleary stleary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test does not restore default locale

2 participants

@Simulant87 @stleary
Morty Proxy This is a proxified and sanitized view of the page, visit original site.