Allow custom placeholders for deeply nested forms #160
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would always replace all instances of NEW_RECORD. With this change you you can have diferent placeholders at different levels. For instance When building a survey with pages and fields you can have something like:
```erb
<form data-controller=“nested-form” data-nested-form-new-record-placeholder-value=“NEW_PAGE_RECORD”>
<!— … ->
<div data-controller=“nested-form” data-nested-form-new-record-placeholder-value=“NEW_FIELD_RECORD”>
<!— … —>
</div>
</form>
```
|
@jbennett I'm needing this nested support too and this looks like an elegant solution. Any idea on the failing tests? |
|
@jbennett @guillaumebriday-pa I submitted an alternative test that doesn't trigger the weird console errors here: jbennett#1 Hope fully that would suffice to land this feature in the main repo and get a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would always replace all instances of NEW_RECORD. With this change you you can have diferent placeholders at different levels. For instance When building a survey with pages and fields you can have something like:
This would be an alternative solution to #150