Use pretty JSON to reduce risk of going over 1k character per line limit #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://sendgrid.com/docs/API_Reference/SMTP_API/using_the_smtp_api.html #-Requirements-and-Limitations, all lines in a header must be under 1,000 characters. By using [`JSON.pretty_generate`](http://flori.github.io/json/doc/classes/JSON.html#method-i-pretty_generate), arrays will be wrapped, reducing the likelihood of exceeding this limit, with the exception being if some element in an array is itself over 1k long.
| end | ||
|
|
||
| header_opts.to_json.gsub(/(["\]}])([,:])(["\[{])/, '\\1\\2 \\3') | ||
| JSON.pretty_generate(header_opts).gsub(/(["\]}])([,:])(["\[{])/, '\\1\\2 \\3') |
Author
There was a problem hiding this comment.
Might not even need the gsub at all...
2.3.0 :007 > puts ({a: [1,2,3]}).to_json
{"a":[1,2,3]}
=> nil
2.3.0 :008 > puts JSON.pretty_generate(a: [1, 2, 3])
{
"a": [
1,
2,
3
]
}
=> nil
Author
|
I have now found out that ActionMailer takes care of wrapping lines, which must be why you had the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to [Sendgrid's SMTP API documentation](
https://sendgrid.com/docs/API_Reference/SMTP_API/using_the_smtp_api.html
-Requirements-and-Limitations), all lines in a header must be under
1,000 characters. By using
JSON.pretty_generate, arrays (e.g. multiple recipients and substitutions) will be wrapped, reducing the likelihood of exceeding this limit, with the exception being if some element in an array is itself over 1,000 characters long.