Update main.scss to add vertical Scroll Bar#14
Update main.scss to add vertical Scroll Bar#14TheodoreChu wants to merge 1 commit intostandardnotes:masterstandardnotes/code-editor:masterfrom TheodoreChu:patch-1Copy head branch name to clipboard
Conversation
There's currently no scrolling. Adding this line with the Inspector makes scrolling work on my Windows 10 Desktop app
|
Hmm I never noticed that it was missing a scrollbar 🤔Although I tested this on Mac and it didn't add the scrollbar. Which platforms/browsers did you test it with? |
|
Here's what I have on Windows 10 Desktop app v3.4.1:
The scrollbar appears for me when I add the |
|
I tried the CSS change (by adding L63 in main.scss and compiling with grunt, then serving locally) on Linux Firefox and desktop, and can verify that it works well on those platforms. Not sure why it doesn't work on mac...
|
|
I do wonder why CodeMirror's default CSS has this property explicitly set to none (iirc). Perhaps they are meant to handle their own scrolling? |
|
@mobitar , you're right, Maybe the missing scroll bar is a result of setting Setting width to 100% pushes the scroll bar out since overflow is hidden. This is what it looks like with width set to 100%. Notice the padding (in purple) on the right is missing This is what it looks like with width unset. I think removing the |
|
Oh, yeah, nice catch! Fixed in latest commit. |
There's currently no vertical scroll bar. Adding this line with the Inspector adds the vertical scroll bar on my Windows 10 Desktop, Firefox, and Google Chrome web apps. I have not tested it on mobile, and I have not tried compiling the editor with this addition.