Switch to builder model #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
In an effort to refactor this package to easily extend it to support #70, this PR refactors the item creation code to use a new
Builderpattern. The builder pattern is defined in astactools.buildernamespace, which yanks code from stac-utils/stactools#268. I think this is a good real-world exercise of the builder pattern, with the hopes that lessons learned here can be moved back to stactools.This is a non-breaking change, there's no real changes to the generated STAC objects (just a couple of trivial re-orderings of the attributes).
I did deprecate two of the COG-creation functions, since they have been superceded by the builder. The deprecation remarks that the functions will be removed in v0.4.0 (two "major" releases from now).
PR checklist:
scripts/format).scripts/lint).scripts/test).