Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Keywords #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pholleway merged 2 commits into from
Mar 9, 2022
Merged

Add Keywords #54

pholleway merged 2 commits into from
Mar 9, 2022

Conversation

@pholleway
Copy link
Contributor

@pholleway pholleway commented Mar 8, 2022

Related Issue(s): Need to add keywords to collection.json file.

Description: Added keywords from Planetary Computer list.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Example STAC Catalog has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@pholleway
Copy link
Contributor Author

pholleway commented Mar 8, 2022

Added keywords that would apply to all dataset, which are: NASA, MODIS, Satellite, Remote Sensing, Imagery, and Global.

I am going back through to add the unique keywords for each product next.

@pholleway pholleway requested a review from gadomski March 8, 2022 22:44
@pholleway
Copy link
Contributor Author

pholleway commented Mar 8, 2022

Also, it looks like a few metadata json files are are missing in each MYD dataset. I'm not what is going on there, but wanted to let you know. Did a merge go wrong?

@gadomski
Copy link
Contributor

gadomski commented Mar 9, 2022

Also, it looks like a few metadata json files are are missing in each MYD dataset. I'm not what is going on there, but wanted to let you know. Did a merge go wrong?

No, I added a "fallback" mechanism here: bc1a4bf. Basically, if a fragment is identical between products from different sensors (e.g. MOD and MYD), you can omit one, and it'll fall back to another one.

gadomski
gadomski requested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some MODIS products that would fall under Land Cover, Fire, and maybe Precipitation, correct? If so, we should add those as well.

@pholleway
Copy link
Contributor Author

pholleway commented Mar 9, 2022

We have some MODIS products that would fall under Land Cover, Fire, and maybe Precipitation, correct? If so, we should add those as well.

Added each of the keywords that apply to each unique data product now. Words included are "Reflectance", "Water", "Temperature", "Forest", and "Fire".

@pholleway pholleway requested a review from gadomski March 9, 2022 16:00
@pholleway pholleway merged commit b391541 into main Mar 9, 2022
@gadomski gadomski deleted the keywords branch March 9, 2022 17:30
@gadomski gadomski mentioned this pull request Mar 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pholleway @gadomski
Morty Proxy This is a proxified and sanitized view of the page, visit original site.