Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ROX-33207: Fix ImageV2 SearchListImages query #19084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajheflin wants to merge 3 commits into
base: master
Choose a base branch
Loading
from
Open

ROX-33207: Fix ImageV2 SearchListImages query #19084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
722bb16
Fix query in GetListImagesView function for ImageV2
ajheflin Feb 18, 2026
463cee8
switch to use direct db column instead of doing it with an aggregate …
ajheflin Feb 18, 2026
4ca14a1
Revert token_service changes
ajheflin Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 central/imagev2/datastore/store/postgres/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,7 @@ func (s *storeImpl) GetListImagesView(ctx context.Context, q *v1.Query) ([]*view
selects := []*v1.QuerySelect{
search.NewQuerySelect(search.ImageSHA).Proto(),
search.NewQuerySelect(search.ImageName).Proto(),
search.NewQuerySelect(search.ComponentCount).Proto(),
search.NewQuerySelect(search.ImageComponentCount).Proto(),
search.NewQuerySelect(search.ImageCVECount).Proto(),
search.NewQuerySelect(search.FixableCVECount).Proto(),
search.NewQuerySelect(search.ImageCreatedTime).Proto(),
Expand Down
2 changes: 1 addition & 1 deletion 2 central/imagev2/views/list_image_view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
type ListImageV2View struct {
Digest string `db:"image_sha"`
Name string `db:"image"`
ComponentCount int32 `db:"component_count"`
ComponentCount int32 `db:"image_component_count"`
CVECount int32 `db:"image_cve_count"`
FixableCVECount int32 `db:"fixable_cve_count"`
Created *time.Time `db:"image_created_time"`
Expand Down
2 changes: 1 addition & 1 deletion 2 generated/storage/image_v2.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions 1 pkg/search/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ var (
ImageUser = newFieldLabel("Image User")
ImageCommand = newFieldLabel("Image Command")
ImageCVECount = newFieldLabel("Image CVE Count")
ImageComponentCount = newFieldLabel("Image Component Count")
ImageEntrypoint = newFieldLabel("Image Entrypoint")
ImageLabel = newFieldLabel("Image Label")
ImageVolumes = newFieldLabel("Image Volumes")
Expand Down
2 changes: 1 addition & 1 deletion 2 proto/storage/image_v2.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ message ImageV2 {

message ScanStats {
// Caching component count to avoid re-calculating it by joining on the component table.
int32 component_count = 1; // @gotags: search:"Component Count,hidden"
int32 component_count = 1; // @gotags: search:"Image Component Count,hidden"

// Caching cve count to avoid re-calculating it by joining on the cve table.
int32 cve_count = 2; // @gotags: search:"Image CVE Count,hidden"
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.