feat(helm): support admission control failurePolicy configuration#13926
Merged
vladbologa merged 2 commits intomasterstackrox/stackrox:masterfrom Jan 23, 2025
vb/admission-control-failurepolicystackrox/stackrox:vb/admission-control-failurepolicyCopy head branch name to clipboard
Merged
feat(helm): support admission control failurePolicy configuration#13926vladbologa merged 2 commits intomasterstackrox/stackrox:masterfrom vb/admission-control-failurepolicystackrox/stackrox:vb/admission-control-failurepolicyCopy head branch name to clipboard
vladbologa merged 2 commits intomasterstackrox/stackrox:masterfrom
vb/admission-control-failurepolicystackrox/stackrox:vb/admission-control-failurepolicyCopy head branch name to clipboard
Conversation
Contributor
|
Images are ready for the commit at 81f27fc. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13926 +/- ##
==========================================
- Coverage 48.85% 48.84% -0.01%
==========================================
Files 2496 2496
Lines 180747 180751 +4
==========================================
- Hits 88296 88292 -4
- Misses 85436 85444 +8
Partials 7015 7015
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/test ocp-4-12-nongroovy-e2e-tests |
9 tasks
mclasmeier
approved these changes
Jan 23, 2025
Contributor
mclasmeier
left a comment
There was a problem hiding this comment.
Two nits. Otherwise 🚢 .
Thanks!
image/templates/helm/stackrox-secured-cluster/templates/admission-controller.yaml
Outdated
Show resolved
Hide resolved
image/templates/helm/stackrox-secured-cluster/templates/admission-controller.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Moritz Clasmeier <111092021+mclasmeier@users.noreply.github.com>
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opened this PR for testing #13838 on CI
User-facing documentation
Testing and quality
Automated testing
How I validated my change
See #13838