Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

left-join-correction#641

Merged
general-kroll-4-life merged 1 commit into
mainstackql/stackql:mainfrom
bugfix/left-join-to-outerstackql/stackql:bugfix/left-join-to-outerCopy head branch name to clipboard
Apr 4, 2026
Merged

left-join-correction#641
general-kroll-4-life merged 1 commit into
mainstackql/stackql:mainfrom
bugfix/left-join-to-outerstackql/stackql:bugfix/left-join-to-outerCopy head branch name to clipboard

Conversation

@general-kroll-4-life

@general-kroll-4-life general-kroll-4-life commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Description

  • Correction of left join from defective inner join implementation to proper left outer join implementation.
  • Updated robot test Subquery Left Joined With Aliasing and Name Collision.
  • Updated robot test Inner Join Users Cross Cloud Fuzzy Match.
  • Added robot test Inner Join Negative LHS Inline.
  • Added robot test Inner Join Positive LHS Inline.
  • Added robot test Left Join Negative LHS Inline.
  • Added robot test Left Join Positive LHS Inline.
  • Added robot test View Left Join View Returns Results.
  • Added robot test View Left Join Subquery Returns Results.
  • Added robot test View Left Join Materialized View Returns Results.

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

Closes #642

Evidence

  • Updated robot test Subquery Left Joined With Aliasing and Name Collision.
  • Updated robot test Inner Join Users Cross Cloud Fuzzy Match.
  • Added robot test Inner Join Negative LHS Inline.
  • Added robot test Inner Join Positive LHS Inline.
  • Added robot test Left Join Negative LHS Inline.
  • Added robot test Left Join Positive LHS Inline.
  • Added robot test View Left Join View Returns Results.
  • Added robot test View Left Join Subquery Returns Results.
  • Added robot test View Left Join Materialized View Returns Results.

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

N/A.

Tech Debt

No technical debt is added in this change.

Summary:

- Correction of `left join` from defective `inner join` implementation to proper `left outer join` implementation.
- Updated robot test `Subquery Left Joined With Aliasing and Name Collision`.
- Updated robot test `Inner Join Users Cross Cloud Fuzzy Match`.
- Added robot test `Inner Join Negative LHS Inline`.
- Added robot test `Inner Join Positive LHS Inline`.
- Added robot test `Left Join Negative LHS Inline`.
- Added robot test `Left Join Positive LHS Inline`.
- Added robot test `View Left Join View Returns Results`.
- Added robot test `View Left Join Subquery Returns Results`.
- Added robot test `View Left Join Materialized View Returns Results`.
@general-kroll-4-life general-kroll-4-life merged commit 3479048 into main Apr 4, 2026
19 checks passed
@general-kroll-4-life general-kroll-4-life deleted the bugfix/left-join-to-outer branch April 4, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Left join should be outer

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.