Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Opt-in support for including templates/*/node_modules in lessons #201

Copy link
Copy link
@AriPerkkio

Description

@AriPerkkio
Issue body actions

Is your feature request related to a problem?

In #198 we hard-coded node_modules to be excluded from templates. However in some cases users might want to have pre-optimized node_modules available in lessons. This featue should be opt-in, as most users will likely not need it and configuring such modules can be tricky.

Describe the solution you'd like.

Not yet sure which way would be better:

  1. Define ignore patterns in templates:
---
type: lesson
template:
  name: default
  ignoredFiles: ["utils/**.js", "node_modules"]
---
---
type: lesson
template:
  name: default
  ignoredFiles: [] # Don't ignore any files, e.g. node_modules
---

However this can be tricky as <template-name>.template.json files are built in advance, before metadata is parsed.

  1. Define ignore patterns in .tk-config.json
{
  "extends": "../default",
  "ignoredFiles": []
}

This would work well for <template-name>.template.json files too, but now exclusion is on template-level and cannot be defined per-lesson/part/chapter.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.