Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Fix/179 pass allowed errors to nested crud handlers#208

Merged
fomalhautb merged 27 commits intostack-auth:devstack-auth/stack-auth:devfrom
kfahad5607:fix/179_pass-allowed-errors-to-nested-crud-handlerskfahad5607/stack:fix/179_pass-allowed-errors-to-nested-crud-handlersCopy head branch name to clipboard
Aug 28, 2024
Merged

Fix/179 pass allowed errors to nested crud handlers#208
fomalhautb merged 27 commits intostack-auth:devstack-auth/stack-auth:devfrom
kfahad5607:fix/179_pass-allowed-errors-to-nested-crud-handlerskfahad5607/stack:fix/179_pass-allowed-errors-to-nested-crud-handlersCopy head branch name to clipboard

Conversation

@kfahad5607
Copy link
Contributor

Fixed #179 by passing StatusError into allowedErrorTypes for error propagation.

Route handler changes:

  • currentUserCrudHandlers.onRead
  • currentUserCrudHandlers.onUpdate
  • currentUserCrudHandlers.onDelete

fomalhautb and others added 27 commits August 4, 2024 23:16
* team invitation wip

* implemented handler

* team invitation callback wip

* added team invitation frontend

* fixed listCurrentUserTeamPermissions

* added team invitation email template

* fixed bugs

* fixed verification code handler

* added more checks to team invitation verification

* fixed team invitation page

* restructured verification code handler

* fixed frontend

* fixed team invitation tests

* added more team invitation test

* fixed bug

* added migration file

* removed unused code
* Added entity checks to provide better errors in API for 'server' access type

* Removed 'ensureUserTeamPermissionExist', changed permissionId type to string in 'ensureUserHasTeamPermission'

* added different error types for user team permission

---------

Co-authored-by: Fahad Khan <fahad.khan@net-mon.net>
Co-authored-by: Zai Shi <zaishi00@outlook.com>
…9_pass-allowed-errors-to-nested-crud-handlers
@vercel
Copy link

vercel bot commented Aug 27, 2024

Someone is attempting to deploy a commit to the Stack Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ fomalhautb
✅ kfahad5607
✅ N2D4
❌ Fahad Khan


Fahad Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fomalhautb fomalhautb merged commit 57bc32d into stack-auth:dev Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Internal Server Error Instead of Proper Error When Nested CRUD Handler Throws Error

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.