Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bug: Improper Handling of Request Body Parameters in User and Team Creation APIs #172

Copy link
Copy link
@kfahad5607

Description

@kfahad5607
Issue body actions

I have identified a few issues with the server APIs. Some APIs are accepting data in the request body that is not being used in the route handlers.

Issues with following APIs

1. Create User

  • Issue: When creating a new user, the API accepts selected_team_id, but the route handler does not make use of selected_team_id.
  • Untitled design (1)

2. Create a Team

  • Issue: When creating a new team, the API accepts profile_image_url, but the route handler does not add the profile_image_url to the newly created team.
  • Untitled design

Probable Solutions

1. Create User

  • Solution 1: Do not accept selected_team_id at all, as it does not make sense to ask for a team ID when the membership does not exist.
  • Solution 2: Create the membership between the newly created user and selected_team_id, then make the team the selected team.

2. Create a Team

  • Solution: Pass profile_image_url while creating the new team.

Additional Notes:

I would love to work on this issue. Please assign it to me if possible.

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.