Drop net6.0 target #1580
Merged
Drop net6.0 target #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test failure is unrelated, see #1253 |
Rob-Hague
reviewed
Feb 2, 2025
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
for some reason this made the compiler suddenly realize that the plain text variables are unused.
this doesn't work in Directory.Build.props, moved it to Directory.Build.targets.
seems like the warnings were (somehow) disabled here before and were fixed by the previous TargetFrameworkIdentifier change.
Rob-Hague
approved these changes
Feb 2, 2025
Rob-Hague
reviewed
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 6 is EOL since last November. Also simplified a lot of .NET version specific conditions in the process.