Migrate to NuGet Central Package Management #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Just want to double check the exclude, not sure why there would be no build warnings anymore |
Contributor
Author
|
I can only reproduce the original warning with Testcontainers <= 3.5.0 which depended on SSH.NET 2020.0.2 . With Testcontainers >= 3.6.0 (which depends on SSH.NET 2023.0.0), the warning disappears. Still no idea why this makes a difference though. |
drieseng
requested changes
Sep 11, 2024
drieseng
approved these changes
Sep 11, 2024
Rob-Hague
approved these changes
Sep 11, 2024
Collaborator
Rob-Hague
left a comment
There was a problem hiding this comment.
Thanks for checking the build warnings. Let's be optimistic that it won't reoccur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates to Central Package Management . Versions stay the same, so there is no functional difference.
Additional changes I made as part of this:
[1.0.0,)syntax with1.0.0since these are equivalent, see docsVersionOverridehere since the version has no meaning anyway.