Fix empty --password handling in CLI option parsing#35
Merged
srichs merged 1 commit intomainsrichs/python-veracrypt:mainfrom Feb 13, 2026
codex/review-code-for-improvementssrichs/python-veracrypt:codex/review-code-for-improvementsCopy head branch name to clipboard
Merged
Fix empty --password handling in CLI option parsing#35srichs merged 1 commit intomainsrichs/python-veracrypt:mainfrom codex/review-code-for-improvementssrichs/python-veracrypt:codex/review-code-for-improvementsCopy head branch name to clipboard
srichs merged 1 commit intomainsrichs/python-veracrypt:mainfrom
codex/review-code-for-improvementssrichs/python-veracrypt:codex/review-code-for-improvementsCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_get_passwordpreviously caught allValueErrors and treated an explicitly empty--password//passwordvalue as if the option were absent, which masks invalid input.Description
_get_passwordto first check for the presence of the password flag and return(None, -1)only when the flag is missing, and to still raiseValueErrorwhen the flag is present but has no value, and addtest_get_password_empty_value_raisesto cover this behavior.Testing
pytest -qand the test suite passed:43 passed.Codex Task