Add initial QuestDB support with simple SELECT generator (Fixes #457) #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrigger
reviewed
Nov 2, 2025
Contributor
mrigger
left a comment
There was a problem hiding this comment.
Thanks, this is great! We currently don't have a CI/CD test for QuestDB. Do you think it would be possible to add one first before adding new features?
Contributor
There was a problem hiding this comment.
Seems like an accidental commit.
| errors.add("missing required column"); | ||
| errors.add("table does not exist"); | ||
| errors.add("permission denied"); | ||
| errors.add("syntax error in INSERT statement"); |
Contributor
There was a problem hiding this comment.
Syntax errors are always unexpected, so we should fix this in the generator.
| return r.getInteger(0, 3); | ||
| case TRUNCATE: | ||
| return r.getInteger(0, 5); | ||
| case UPDATE: |
Contributor
There was a problem hiding this comment.
I think we should only add new features once we have a CI/CD that works for a given QuestDB version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for QuestDB in SQLancer.
Changes included:
QuestDBQueryGenerator.javato generate simple SELECT queries.QuestDBProvider.javato use the new generator.--num-threads 1) for stability during testing.Currently, only basic SELECT queries are supported. INSERT, DELETE, and more complex queries will be added in future iterations.
This addresses Issue #457 and lays the foundation for full QuestDB testing support.