Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Eklavya-Sahani
Copy link

fixes a bug in sqlancer that will always throw AssertionError if --log-each-select is set to false. The issue was identified in main.java and has been resolved by updating the logic and improving error handling. The fix has been tested to ensure correct execution and prevent regressions. This improves sqlancer’s stability and accuracy for database testing. 🚀

@Eklavya-Sahani
Copy link
Author

Hi @mrigger @albertZhangTJ , @suyZhong could you please review this PR? It resolves issue #1205 by preventing AssertionError when --log-each-select is false. Thank you!

@Eklavya-Sahani
Copy link
Author

Hi maintainers, the GitHub workflows for this PR haven’t started. Could you please enable workflows for forked contributions so I can get test results and reviews? Thanks!

@Eklavya-Sahani
Copy link
Author

Hi @mrigger, @albertZhangTJ, @suyZhong 👋

This PR fixes issue #1205 by preventing an AssertionError that would occur when --log-each-select is set to false. The logic in Main.java has been updated and tested to ensure proper behavior and avoid regressions.

Also, I noticed that the GitHub Actions workflows haven’t started for this forked PR. Could you please enable workflows for external contributions so the required tests can run? This will help in getting the review and merge process moving forward.

Thank you for your time and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.