Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 679c553

Browse filesBrowse files
rickeylevrickeylev
authored
chore: remove find_requirements re-export from bazel_tools (bazel-contrib#2484)
This removes re-exporting the `find_requirements` aspect from `@bazel_tools`. The find_requirements aspect is only useful for analyzing the `srcs_version` relationship between targets, which was only needed as part of the Python 2 to 3 upgrade. With Python 2 no longer supported, it's defunct. Removing it entirely because I can't find any real references to it in the wild. It looks entirely unused.
1 parent 42930cc commit 679c553
Copy full SHA for 679c553

File tree

3 files changed

+1
-7
lines changed
Filter options

3 files changed

+1
-7
lines changed

‎CHANGELOG.md

Copy file name to clipboardExpand all lines: CHANGELOG.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Unreleased changes template.
6565

6666
{#v0-0-0-removed}
6767
### Removed
68-
* Nothing removed.
68+
* `find_requirements` in `//python:defs.bzl` has been removed.
6969

7070
{#v1-0-0}
7171
## [1.0.0] - 2024-12-05

‎python/BUILD.bazel

Copy file name to clipboardExpand all lines: python/BUILD.bazel
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ bzl_library(
7171
":py_runtime_info_bzl",
7272
":py_runtime_pair_bzl",
7373
":py_test_bzl",
74-
"//python/private:bazel_tools_bzl",
7574
],
7675
)
7776

‎python/defs.bzl

Copy file name to clipboardExpand all lines: python/defs.bzl
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414
"""Core rules for building Python projects."""
1515

16-
load("@bazel_tools//tools/python:srcs_version.bzl", _find_requirements = "find_requirements")
1716
load("//python:py_binary.bzl", _py_binary = "py_binary")
1817
load("//python:py_info.bzl", _PyInfo = "PyInfo")
1918
load("//python:py_library.bzl", _py_library = "py_library")
@@ -34,12 +33,8 @@ current_py_toolchain = _current_py_toolchain
3433

3534
py_import = _py_import
3635

37-
# Re-exports of Starlark-defined symbols in @bazel_tools//tools/python.
38-
3936
py_runtime_pair = _py_runtime_pair
4037

41-
find_requirements = _find_requirements
42-
4338
py_library = _py_library
4439

4540
py_binary = _py_binary

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.