Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 096a04f

Browse filesBrowse files
authored
test: Enable non-ABI3 libs linking test for Windows (bazel-contrib#2461)
Also explicitly include ABI3 in the name of the other Windows-only testcase, since that is the whole point of the test, and no ABI3-only libs exist on non-Windows platforms. ----------- Follow-up of bazel-contrib#1820.
1 parent bc8658a commit 096a04f
Copy full SHA for 096a04f

File tree

Expand file treeCollapse file tree

1 file changed

+1
-10
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-10
lines changed

‎tests/cc/current_py_cc_libs/BUILD.bazel

Copy file name to clipboardExpand all lines: tests/cc/current_py_cc_libs/BUILD.bazel
+1-10Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ current_py_cc_libs_test_suite(name = "current_py_cc_libs_tests")
2020
cc_test(
2121
name = "python_libs_linking_test",
2222
srcs = ["python_libs_linking_test.cc"],
23-
# Windows fails with linking errors, but its not clear why; someone
24-
# with more C + Windows experience will have to figure it out.
25-
# - rickeylev@
26-
target_compatible_with = select({
27-
"@platforms//os:linux": [],
28-
"@platforms//os:osx": [],
29-
"//conditions:default": ["@platforms//:incompatible"],
30-
}),
3123
deps = [
3224
"@rules_python//python/cc:current_py_cc_headers",
3325
"@rules_python//python/cc:current_py_cc_libs",
@@ -41,10 +33,9 @@ cc_test(
4133
# for libs/python3.lib.
4234
# buildifier: disable=native-cc
4335
cc_test(
44-
name = "python_libs_linking_windows_test",
36+
name = "python_abi3_libs_linking_windows_test",
4537
srcs = ["python_libs_linking_test.cc"],
4638
defines = ["Py_LIMITED_API=0x030A0000"],
47-
env = {"HELLO": "world"},
4839
target_compatible_with = ["@platforms//os:windows"],
4940
deps = [
5041
"@rules_python//python/cc:current_py_cc_headers",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.