Configure SimpleClientHttpRequestFactory with timeouts #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edf571a to
17afc4f
Compare
Closes spring-projectsgh-907 Signed-off-by: Luciano Canales <64669280+ljcanales@users.noreply.github.com>
17afc4f to
ff29474
Compare
Member
|
Thank you for your contribution. That's merged and polished now. For 4.0, we are switching to the built-in JDK HTTP Client eliminating the need for |
Contributor
Author
|
Hey @mp911de , Thanks for reviewing! 🚀 Do you have an estimated release date for the Also, should these changes be committed to |
Member
|
2.x is no longer maintained. I think, we could backport the change into 3.1.x. 3.2.0-M1 will ship in April. |
Contributor
Author
|
Sounds great! Thanks! I appreciate the quick update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
SimpleClientHttpRequestFactorycorrectly applies timeout configurations fromClientOptions, maintaining consistency with Apache HttpComponents and OkHttp clients.SimpleClientclass to encapsulateSimpleClientHttpRequestFactorysetup.ClientOptions.Closes gh-907