Modify it to avoid adding runtimeHints for primitive types and array types. #3284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types. Related tickets: spring-projects/spring-data-mongodb#4958 Signed-off-by: ckdgus08 <ckdgus0808@naver.com>
mp911de
reviewed
Jun 4, 2025
| @@ -41,6 +41,10 @@ public static void contributeEntityPath(Class<?> type, GenerationContext context | ||
| return; | ||
| } | ||
|
|
||
| if (type.isPrimitive() || type.isArray()) { |
There was a problem hiding this comment.
Nit: We should use ClassUtils.isPrimitiveOrWrapper(…) and ReflectionUtils.isVoid(…) to avoid adding type hints for primitive wrappers or Kotlin's Unit.
There was a problem hiding this comment.
I don't think we can just skip arrays in here. GraalVM needs reflection hint entries for them in order to allow access to java.lang.Class arrayType(), which (as per documentation) requires metadata for the array type like in this example for HikariCP:
{
"condition": {
"typeReachable": "com.zaxxer.hikari.pool.PoolEntry"
},
"name": "[Ljava.sql.Statement;"
}
christophstrobl
pushed a commit
that referenced
this pull request
Jun 5, 2025
Closes: #3284 See: spring-projects/spring-data-mongodb#4958 Signed-off-by: ckdgus08 <ckdgus0808@naver.com>
christophstrobl
pushed a commit
that referenced
this pull request
Jun 5, 2025
Closes: #3284 See: spring-projects/spring-data-mongodb#4958 Signed-off-by: ckdgus08 <ckdgus0808@naver.com>
christophstrobl
added a commit
that referenced
this pull request
Jun 5, 2025
Revert changes targeting primitive and array types explicitly to extract minimal inversive change switching getPackage().getName() to getPackageName(). Original Pull Request: #3284
christophstrobl
added a commit
that referenced
this pull request
Jun 5, 2025
Use getPackageName() instead of getPackage().getName(), remove essentially duplicate tests and fix array type handling of Q types by using the arrays component type for assignability checks. Original Pull Request: #3284
christophstrobl
pushed a commit
that referenced
this pull request
Jun 5, 2025
Closes: #3284 See: spring-projects/spring-data-mongodb#4958 Signed-off-by: ckdgus08 <ckdgus0808@naver.com>
christophstrobl
added a commit
that referenced
this pull request
Jun 5, 2025
Revert changes targeting primitive and array types explicitly to extract minimal inversive change switching getPackage().getName() to getPackageName(). Original Pull Request: #3284
christophstrobl
pushed a commit
that referenced
this pull request
Jun 5, 2025
Closes: #3284 See: spring-projects/spring-data-mongodb#4958 Signed-off-by: ckdgus08 <ckdgus0808@naver.com>
christophstrobl
added a commit
that referenced
this pull request
Jun 5, 2025
Revert changes targeting primitive and array types explicitly to extract minimal inversive change switching getPackage().getName() to getPackageName(). Original Pull Request: #3284
|
Thank you @ckdgus08 for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets: spring-projects/spring-data-mongodb#4958