Removing the shade module #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a6b5fe to
a2d50c2
Compare
a2d50c2 to
0b6d39b
Compare
| <artifactId>maven-filtering</artifactId> | ||
| <version>${maven-filtering.version}</version> | ||
| </dependency> | ||
| <dependency> |
Contributor
Author
There was a problem hiding this comment.
Important! We need to be aligned with Maven and Boot. Otherwise we get a 3.x version as a transitive and MethodMissing
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
d04c618 to
02a85e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this module was created to fix some issues with depedency hell between boot, maven, gradle and sping cloud. It seems that these problems are long gone.
Removing this should simplify the build a lot.